Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include cuda_runtime in cu.hpp #297

Merged
merged 4 commits into from
Jul 23, 2024
Merged

include cuda_runtime in cu.hpp #297

merged 4 commits into from
Jul 23, 2024

Conversation

loostrum
Copy link
Member

Description

Include cuda_runtime.h in cu.hpp.

Related issues:
See #296 for a description of the problem this PR solves.

@loostrum loostrum requested a review from csbnw July 23, 2024 10:30
include/cudawrappers/cu.hpp Show resolved Hide resolved
@loostrum
Copy link
Member Author

Pre-commit reverted your change @csbnw, perhaps it doesn't like the underscore...

Copy link
Contributor

@csbnw csbnw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure what pre-commit is up to. I don't like its auto-formatting in this case, but I'll approve this PR anyway.

@loostrum
Copy link
Member Author

Perhaps we can fiddle with some of pre-commit's settings to avoid weird issues like this. Weirdly it did pass locally (on my AMD machine, on DAS6 pre-commit doesn't work at all anymore)

@loostrum loostrum merged commit a8fb18a into main Jul 23, 2024
7 checks passed
@loostrum loostrum deleted the include-runtime branch July 23, 2024 11:42
matmanc pushed a commit that referenced this pull request Jan 20, 2025
* include cuda_runtime in cu.hpp
---------

Co-authored-by: Bram Veenboer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants