Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nvml interface #308

Merged
merged 6 commits into from
Jan 6, 2025
Merged

Update nvml interface #308

merged 6 commits into from
Jan 6, 2025

Conversation

csbnw
Copy link
Contributor

@csbnw csbnw commented Jan 6, 2025

Description

  • Remove the unused context argument from the nvml::Device constructor
  • Make nvml::Device functions const
  • Add missing checkNvmlCall

Related issues:

N.A.

Instructions to review the pull request

  • Check that CHANGELOG.md has been updated if necessary

@csbnw csbnw added the enhancement New feature or request label Jan 6, 2025
@csbnw csbnw requested a review from wvbbreu January 6, 2025 12:06
@csbnw csbnw self-assigned this Jan 6, 2025
wvbbreu
wvbbreu approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@wvbbreu wvbbreu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, please retrigger automated tests before merging.

@csbnw csbnw merged commit ad13d8f into main Jan 6, 2025
6 checks passed
@csbnw csbnw deleted the update-nvml branch January 6, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wvbbreu wvbbreu wvbbreu approved these changes

Assignees

@csbnw csbnw

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@csbnw @wvbbreu