Fix for night arming option #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There appears to be a typo when changing the state of a partition where the night arming option is not passed through correctly.
|
Looks good to me. Thanks for the PR! |
|
These three lines solved an issue with night arming that has been driving me crazy for weeks!! Thanks for the quick merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There appears to be a typo when changing the state of a partition where the night arming option is not passed through correctly. Instead of the night arming mode in the configuration being mapped to the night arming option passed through to alarm.com, it's mapped to the silent arming option, which would mean 1) the night arming option isn't actually ever set and 2) the silent arming option is being overwritten.