Some small fixes for lineTicks in cpu profiler

node-inspector · May 12, 2015 · 1a24629 · 1a24629
1 parent 483eea5
commit 1a24629
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 8 deletions.
diff --git a/src/cpu_profile_node.cc b/src/cpu_profile_node.cc
@@ -13,18 +13,18 @@ namespace nodex {
 
   uint32_t ProfileNode::UIDCounter = 1;
 
-  #if (NODE_MODULE_VERSION >= 42)
-  static Handle<Value> GetLineTicks(const CpuProfileNode* node) {
+#if (NODE_MODULE_VERSION >= 42)
+  Handle<Value> ProfileNode::GetLineTicks_(const CpuProfileNode* node) {
     NanEscapableScope();
 
-    unsigned int count = node->GetHitLineCount();
+    uint32_t count = node->GetHitLineCount();
     v8::CpuProfileNode::LineTick *entries = new v8::CpuProfileNode::LineTick[count];
     bool result = node->GetLineTicks(entries, count);
 
     Local<Value> lineTicks;
     if (result) {
       Local<Array> array = NanNew<Array>(count);
-      for (unsigned int index = 0; index < count; index++) {
+      for (uint32_t index = 0; index < count; index++) {
         Local<Object> tick = NanNew<Object>();
         tick->Set(NanNew<String>("line"),     NanNew<Integer>(entries[index].line));
         tick->Set(NanNew<String>("hitCount"), NanNew<Integer>(entries[index].hit_count));
@@ -69,7 +69,7 @@ namespace nodex {
     profile_node->Set(NanNew<String>("children"),      children);
 
 #if (NODE_MODULE_VERSION >= 42)
-    auto lineTicks = GetLineTicks(node);
+    Handle<Value> lineTicks = GetLineTicks_(node);
     if (!lineTicks->IsNull()) {
       profile_node->Set(NanNew<String>("lineTicks"), lineTicks);
     }

diff --git a/src/cpu_profile_node.h b/src/cpu_profile_node.h
@@ -7,9 +7,14 @@
 namespace nodex {
 
 class ProfileNode {
- public:
-   static v8::Handle<v8::Value> New(const v8::CpuProfileNode* node);
-   static uint32_t UIDCounter;
+  public:
+    static v8::Handle<v8::Value> New(const v8::CpuProfileNode* node);
+    static uint32_t UIDCounter;
+
+  private:
+#if (NODE_MODULE_VERSION >= 42)
+    static v8::Handle<v8::Value> GetLineTicks_(const v8::CpuProfileNode* node);
+#endif
 };
 
 }