-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
module: fixing url change in load sync hook chain #56402
base: main
Are you sure you want to change the base?
Conversation
Review requested:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! It looks okay to me. The test is fine, but I think it could be improved/simplified.
I'm gonna tag the original author of this for review since she has more context than me.
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56402 +/- ##
==========================================
+ Coverage 88.53% 89.17% +0.63%
==========================================
Files 657 662 +5
Lines 190718 191751 +1033
Branches 36603 36905 +302
==========================================
+ Hits 168861 170993 +2132
+ Misses 15024 13620 -1404
- Partials 6833 7138 +305
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test for import('foo')
as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks, I'd still prefer to see a test for import
, but this is only touching CJS loader, so it's fine to leave that to a follow-up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
Co-authored-by: Antoine du Hamel <[email protected]>
Co-authored-by: Joyee Cheung <[email protected]>
Fixes: #56376