Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: initialize FSReqWrapSync in path that uses it #56613

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

src: initialize FSReqWrapSync in path that uses it #56613

wants to merge 1 commit into from
+1 −1

Conversation

targos
Copy link
Member

@targos targos commented Jan 15, 2025 •
edited
Loading

The goal is to fix this error reported by Coverity:

image

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jan 15, 2025
@targos
Copy link
Member Author

targos commented Jan 15, 2025

Well it looks like this is breaking some tests. I'll come back to it when I'm on my Mac

@codecov Codecov
Copy link

codecov bot commented Jan 15, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.19%. Comparing base (c8df98d) to head (d590d06).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #56613      +/-   ##
==========================================
- Coverage   89.20%   89.19%   -0.01%     
==========================================
  Files         662      662              
  Lines      191816   191819       +3     
  Branches    36926    36921       -5     
==========================================
- Hits       171102   171090      -12     
- Misses      13559    13571      +12     
- Partials     7155     7158       +3
Files with missing lines Coverage Δ
src/node_file.cc 77.23% <100.00%> (ø)

... and 35 files with indirect coverage changes

@targos targos force-pushed the coverity_node_file branch from 2b07c23 to d590d06 Compare January 15, 2025 17:26
@targos
Copy link
Member Author

targos commented Jan 15, 2025

Apparently it's important that the stack_buffer still lives after use, so I updated to only change the variable that was flagged by Coverity.

@targos targos changed the title src: initialize variables in paths that use them src: initialize FSReqWrapSync in path that uses it Jan 15, 2025
@targos
Copy link
Member Author

targos commented Jan 16, 2025

CI looks good now. Can I have a new review?

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 16, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 16, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64531/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64532/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/64537/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@targos @nodejs-github-bot @jasnell @anonrig