src: check process wrap type emptiness in ParseStdioOptions #56625
+28
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Co-authored-by: Jake Yuesong Li <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #56625 +/- ##
==========================================
+ Coverage 89.17% 89.20% +0.03%
==========================================
Files 662 662
Lines 191761 191896 +135
Branches 36905 36935 +30
==========================================
+ Hits 171006 171185 +179
+ Misses 13620 13559 -61
- Partials 7135 7152 +17
|
cjihrig
reviewed
Jan 16, 2025
| @@ -427,6 +427,9 @@ ChildProcess.prototype.spawn = function(options) { | |||
|
|
|||
| for (i = 0; i < stdio.length; i++) { | |||
| const stream = stdio[i]; | |||
| if (stream == null) { | |||
There was a problem hiding this comment.
There is a lot of input validation in lib/child_process.js already. Can that be updated to handle this case instead of handling it here and in the binding layer?
| @@ -122,8 +122,12 @@ class ProcessWrap : public HandleWrap { | |||
| for (uint32_t i = 0; i < len; i++) { | |||
| Local<Object> stdio = | |||
| stdios->Get(context, i).ToLocalChecked().As<Object>(); | |||
| Local<Value> type = | |||
| stdio->Get(context, env->type_string()).ToLocalChecked(); | |||
| v8::MaybeLocal<Value> maybe_type = | |||
There was a problem hiding this comment.
I'm not sure that we need to change the binding layer to fix this. If we do, it's good to get rid of ToLocalChecked() usage, but can you add using v8::MaybeLocal to the top of the file and drop the v8:: here.
| v8::MaybeLocal<Value> maybe_type = | ||
| stdio->Get(context, env->type_string()); | ||
| if (maybe_type.IsEmpty()) { | ||
| return env->ThrowTypeError("Not a valid JS type"); |
There was a problem hiding this comment.
I think we would want to use one of the errors from https://nodejs.org/api/errors.html here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #56531