module: integrate TypeScript into compile cache #56629
Open
+829
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
This integrates TypeScript into the compile cache by caching the transpilation (either type-stripping or transforming) output in addition to the V8 code cache that's generated from the transpilation output. Locally this speeds up loading with type stripping of `benchmark/fixtures/strip-types-benchmark.ts` by ~65% and loading with type transforms of `fixtures/transform-types-benchmark.ts` by ~128%. When comparing loading .ts and loading pre-transpiled .js on-disk with the compile cache enabled, previously .ts loaded 46% slower with type-stripping and 66% slower with transforms compared to loading .js files directly. After this patch, .ts loads 12% slower with type-stripping and 22% slower with transforms compared to .js. (Note that the numbers are based on microbenchmark fixtures and do not necessarily represent real-world workloads, though with bigger real-world files, the speed up should be more significant).
github-actions
bot
removed
the
request-ci
GeoffreyBooth
approved these changes
Jan 16, 2025
Comment on lines
+96
to
+97
| * @typedef {object} TypeScriptOptions | ||
| * @property {'transform'|'strip-only'} mode Mode. |
There was a problem hiding this comment.
Nit, so you can avoid repeating 'strip-only'|'transform' later
Suggested change
| * @typedef {object} TypeScriptOptions | |
| * @property {'transform'|'strip-only'} mode Mode. | |
| * @typedef {'strip-only' | 'transform'} TypeScriptMode | |
| * | |
| * @typedef {object} TypeScriptOptions | |
| * @property {TypeScriptMode} mode Mode. |
| @@ -108,6 +120,20 @@ function processTypeScriptCode(code, options) { | |||
| return transformedCode; | |||
| } | |||
|
|
|||
| /** | |||
| * Get the type enum used for compile cache. | |||
| * @param {'strip-only'|'transform'} mode Mode of transpilation. | |||
There was a problem hiding this comment.
Per above.
Suggested change
| * @param {'strip-only'|'transform'} mode Mode of transpilation. | |
| * @param {TypeScriptMode} mode Mode of transpilation. |
| case CachedCodeType::kStrippedTypeScript: | ||
| return "StrippedTypeScript"; | ||
| case CachedCodeType::kTransformedTypeScript: | ||
| return "TransformedTypeScript"; |
There was a problem hiding this comment.
Does this flavor exist? I thought if we were transforming, we were adding source maps. Is there a way to transform without getting source maps?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #56629 +/- ##
========================================
Coverage 89.20% 89.21%
========================================
Files 662 662
Lines 191890 192027 +137
Branches 36928 36956 +28
========================================
+ Hits 171176 171309 +133
- Misses 13554 13555 +1
- Partials 7160 7163 +3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This integrates TypeScript into the compile cache by caching the transpilation (either type-stripping or transforming) output in addition to the V8 code cache that's generated from the transpilation output.
Locally this speeds up loading with type stripping of
benchmark/fixtures/strip-types-benchmark.tsby ~65% and loading with type transforms offixtures/transform-types-benchmark.tsby ~128%.When comparing loading .ts and loading pre-transpiled .js on-disk with the compile cache enabled, previously .ts loaded 46% slower with type-stripping and 66% slower with transforms compared to loading .js files directly.
After this patch, .ts loads 12% slower with type-stripping and 22% slower with transforms compared to .js.
(Note that the numbers are based on microbenchmark fixtures and do not necessarily represent real-world workloads, though with bigger real-world files, the speed up should be more significant).
There are some TODOs left for avoiding the excessive UTF8 transcoding, which depends on swc-project/swc#9851 though the numbers are already good enough that I think that can be done as a follow-up..when swc actually supports it.
With compile cache enabled via
export NODE_COMPILE_CACHE=/tmp:Without compile cache (i.e. there should be no regression when it's not enabled):
Fixes: #54741