Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix up nits #1

Merged
merged 10 commits into from
Jan 14, 2025
Merged

chore: fix up nits #1

merged 10 commits into from
Jan 14, 2025

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves

Summary*

This PR fixes up a few issues:

  • noir-gates-diff commit is old (we've done some updates to this recently)
  • we're currently fuzzing a circuit with no inputs so I've converted that into a regular test.
  • There were a fair few visibility issues in the tests so I've restructured things so we don't need to make the sha256 internals pub(crate)
  • Clippy is angry about some of the rust code.

I've also updated authors to just be the noir team generally as the implementation of this lib is pre-existing.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench requested a review from jtriley2p January 13, 2025 19:49
Copy link
Collaborator

@jtriley2p jtriley2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm; shipp

@jtriley2p jtriley2p merged commit 71cbebf into main Jan 14, 2025
8 of 9 checks passed
@jtriley2p jtriley2p deleted the tf/fixups branch January 14, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants