Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move md functions from atomutils #24

Merged
merged 2 commits into from
Sep 10, 2024
Merged

Move md functions from atomutils #24

merged 2 commits into from
Sep 10, 2024

Conversation

ladinesa
Copy link
Collaborator

@ladinesa ladinesa commented Sep 9, 2024

No description provided.

@ladinesa ladinesa requested a review from JFRudzinski September 9, 2024 13:41
@coveralls
Copy link

coveralls commented Sep 9, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10779782864

Details

  • 403 of 515 (78.25%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.0%) to 82.832%
Changes Missing Coverage Covered Lines Changed/Added Lines %
simulationworkflowschema/molecular_dynamics.py 403 515 78.25%
Totals Coverage Status
Change from base Build 10490968866: -1.0%
Covered Lines: 2369
Relevant Lines: 2860
💛 - Coveralls

@ladinesa
Copy link
Collaborator Author

@JFRudzinski can I merge this?

@JFRudzinski
Copy link
Collaborator

@JFRudzinski can I merge this?

Yes, I think it should be fine 👍

@ladinesa ladinesa merged commit 5631278 into develop Sep 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JFRudzinski JFRudzinski Awaiting requested review from JFRudzinski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ladinesa @coveralls @JFRudzinski