Ensure bmalloc always takes positive size

norihiro · Nov 30, 2024 · 0382723 · 0382723
1 parent 9cb29e2
commit 0382723
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/src/obs-vnc-source-thread.c b/src/obs-vnc-source-thread.c
@@ -127,6 +127,12 @@ static rfbBool vnc_malloc_fb(rfbClient *client)
 
 	debug("vnc_malloc_fb width=%d height=%d\n", client->width, client->height);
 
+	if (client->width <= 0 || client->height <= 0) {
+		blog(LOG_ERROR, "vnc_malloc_fb gets 0-length geometry %dx%d", client->width, client->height);
+		client->frameBuffer = NULL;
+		return FALSE;
+	}
+
 	src->frame.width = client->width;
 	src->frame.height = client->height;
 	set_updateRect(src, client);