added missing 'android_gcm_sender_id' field (#97)

* added missing 'android_gcm_sender_id' field * added android_gcm_sender_id to tests * fixed spacings
norkunas · Aug 28, 2018 · cafc720 · cafc720
1 parent eed4183
commit cafc720
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/src/Resolver/AppResolver.php b/src/Resolver/AppResolver.php
@@ -23,6 +23,8 @@ public function resolve(array $data)
             ->setAllowedTypes('apns_p12_password', 'string')
             ->setDefined('gcm_key')
             ->setAllowedTypes('gcm_key', 'string')
+            ->setDefined('android_gcm_sender_id')
+            ->setAllowedTypes('android_gcm_sender_id', 'string')
             ->setDefined('chrome_key')
             ->setAllowedTypes('chrome_key', 'string')
             ->setDefined('safari_apns_p12')

diff --git a/tests/OneSignal/Tests/Resolver/AppResolverTest.php b/tests/OneSignal/Tests/Resolver/AppResolverTest.php
@@ -24,6 +24,7 @@ public function testResolveWithValidValues()
             'apns_p12' => 'value',
             'apns_p12_password' => 'value',
             'gcm_key' => 'value',
+            'android_gcm_sender_id' => 'value',
             'chrome_key' => 'value',
             'safari_apns_p12' => 'value',
             'chrome_web_key' => 'value',
@@ -60,6 +61,7 @@ public function wrongValueTypesProvider()
             [['apns_p12' => 666]],
             [['apns_p12_password' => 666]],
             [['gcm_key' => 666]],
+            [['android_gcm_sender_id' => 666]],
             [['chrome_key' => 666]],
             [['safari_apns_p12' => 666]],
             [['chrome_web_key' => 666]],