Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to support node20 #157

Merged
merged 4 commits into from
Dec 20, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ jobs:

strategy:
matrix:
node-version: [ '16', '18' ]
node-version: [ '16', '18', '20' ]

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}

Expand Down
2 changes: 1 addition & 1 deletion lib/appdir.js
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ function _findLibraries (appdir, appbin, appexs, disklibs) {
const exe = path.join(appdir, appbin);

const o = {
exe: exe,
exe,
lib: exe,
libs: disklibs
};
Expand Down
12 changes: 6 additions & 6 deletions lib/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -291,10 +291,10 @@ function compile (conf) {
}

module.exports = {
compile: compile,
fromOptions: fromOptions,
fromState: fromState,
helpMessage: helpMessage,
parse: parse,
shortHelpMessage: shortHelpMessage
compile,
fromOptions,
fromState,
helpMessage,
parse,
shortHelpMessage
};
2 changes: 1 addition & 1 deletion lib/fchk.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ module.exports = function (args, types) {
if (args.length !== types.length) {
throw new Error('Incorrect arguments count');
}
const stack = Array(...args).reverse();
const stack = [...args].reverse();
for (const t of types) {
const arg = typeof stack.pop();
if (t && arg !== t) {
Expand Down
6 changes: 3 additions & 3 deletions lib/tools.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ async function execProgram (bin, arg, opt) {
resolve({
stdout: _out.toString(),
stderr: _err.toString(),
code: code
code
});
});
});
Expand Down Expand Up @@ -185,11 +185,11 @@ async function zip (cwd, ofile, src) {
if (use7zip) {
const zipFile = ofile + '.zip';
const args = ['a', zipFile, src];
await execProgram(getTool('7z'), args, { cwd: cwd });
await execProgram(getTool('7z'), args, { cwd });
await renameAsync(zipFile, ofile);
} else {
const args = ['-qry', ofile, src];
await execProgram(getTool('zip'), args, { cwd: cwd });
await execProgram(getTool('zip'), args, { cwd });
}
}

Expand Down
Loading