Add statistics page #105

Nasirdin · 2022-04-25T12:32:20Z

cloudflare-workers-and-pages · 2022-04-25T12:35:06Z

Deploying with Cloudflare Pages

Latest commit:	`31067dd`
Status:	✅ Deploy successful!
Preview URL:	https://a5fe3b97.dash-onout-org.pages.dev

View logs

noxonsu · 2022-04-25T12:47:59Z

dash-onout-org.751b4c66-64e0-4954-ac36-e8c04f2fe98a.log

noxonsu · 2022-04-25T13:55:40Z

https://screenshots.wpmix.net/chrome_MWFDbB8LvjomYVsfxSgfuyUdPJHDKde6.png убрать статистику сверху, т.к. это не оснофной функционал. сделать маленькие ссылки в футере

src/helpers/transaction.ts

src/components/Statistics/index.tsx

src/helpers/transaction.ts

VitaliyShulik · 2022-04-26T04:55:11Z

@shendel @Nasirdin @NotEternal нам нужно установить одни и те же правила по Prettier и по линтеру, чтобы не было каждый раз изменений в коде ненужных...

Disti4ct · 2022-04-26T06:06:20Z

@shendel @Nasirdin @NotEternal нам нужно установить одни и те же правила по Prettier и по линтеру, чтобы не было каждый раз изменений в коде ненужных...

Мне не важно, главное чтобы один стиль был. Можешь свои правила добавить. Для простоты сделать форматирование на любом комите: #80

src/components/Footer/index.tsx

src/constants/index.ts

src/components/Statistics/index.tsx

src/constants/index.ts

src/components/Statistics/index.tsx

VitaliyShulik · 2022-05-11T07:17:16Z

src/constants/index.ts

+    name: 'POLYGON',
+    networkId: 137,
+    apiKey: "4JB4UXHBIE2I5285T18J8SSPUS2M3K7X3V",
+    apiLink: `https://api.polygonscan.com/api?module=account&action=txlist&address=${bonusAndDiscountContractsByNetworkId[SupportedChainId.POLYGON]}&startblock=0&endblock=99999999&page=1&offset=10&sort=asc&apikey=${apiKey.POLYGON}`,


- apiLink !== apiLinkWithParams и следовательно это нужно убрать, параметры запроса у тебя одинаковые, меняются только домены, их тут оставь а параметры создавай перед запросом...

VitaliyShulik · 2022-05-11T07:21:10Z

src/constants/index.ts

@@ -10,20 +10,50 @@ export enum SupportedChainId {
  POLYGON = 137,
 }

+export const apiKey = {


это нужно удалить и так как ссылку генерировать в константах не вариант и использовать statisticUrlsDataByNetwork...

VitaliyShulik · 2022-05-11T07:36:11Z

Логику осталось проверить в деталях. Потому что вчера был профит +16%, а сегодня уже -35% =)

Да желательно бы определить начало недели на понедельник и если сегодня понедельник и продаж 0 то так и писать...

noxonsu · 2022-05-11T08:20:05Z

Да желательно бы определить начало недели на понедельник и если сегодня понедельник и продаж 0 то так и писать...

в этом случае надо смотреть в воскресенье, а не в любой день?

VitaliyShulik · 2022-05-11T08:22:37Z

в этом случае надо смотреть в воскресенье, а не в любой день?

ну если воскресенье лучше - делаем его)

Disti4ct · 2022-05-17T06:09:44Z

src/components/Statistics/index.tsx

+  const getWeek = (date: any, days: number) => {
+    date = new Date(date);
+    const day = date.getDay() + days;
+    const daysOfTheWeek = date.getDate() - day + (day === 0 ? -6 : 1);


Не ясно что за -6 и 1. Как вариант сделать подобное для всех чисел (если я правильно понял):
const MONDAY = 0

src/components/Statistics/index.tsx

Disti4ct · 2022-05-17T06:17:03Z

src/helpers/transaction.ts

@@ -40,7 +39,7 @@ export const importToken = async (
          options: {
            address: cashbackTokenAddress,
            symbol: tokenSymbol,
-            decimals: tokenDecimals,
+            decimals: 10,


Мы уверены что тут 10? Если да, то хотябы сделать константу с названием. Возможно добавить прямо в cashbackToken константы. Если мы не уверены какое кол-во десятичных знаков у токена, то нужно либо запрашивать, либо ломать все. Вдруг мы используем это для расчета (от части так и есть) цены/зарплаты/перевода. И получится изначально 18 в виде константы, а на самом деле 8.

src/components/Statistics/index.tsx

VitaliyShulik · 2022-05-17T08:31:40Z

src/components/Statistics/index.tsx

+
+    statisticUrlsDataByNetworkArray.map(async (Object) => {
+      const tokenRate = await getRate(Object.networkId);
+      const transactionsResults = await getTransactionsResult(Object);


- Что будет с кодом ниже если одного из верхних данных не будет? Нужно обернуть это все в try...catch здесь и в самих этих функциях (getRate and getTransactionsResult) сделать throw если что-то с данные не так к примеру они не пришли...

src/constants/index.ts

src/components/Statistics/index.tsx

VitaliyShulik

На данный момент все окей. @NotEternal посмотри тоже и если окей - мерджим...

Nasirdin added 2 commits April 25, 2022 18:24

add statistics page

bc991ec

Merge branch 'main' into add-statistics-page

84977cd

delete line 138 on Product file

96e2976

error correction

64e7e5d

Nasirdin requested review from VitaliyShulik, Disti4ct and noxonsu April 25, 2022 13:04

noxonsu approved these changes Apr 25, 2022

View reviewed changes

Disti4ct reviewed Apr 25, 2022

View reviewed changes

src/helpers/transaction.ts Outdated Show resolved Hide resolved

Disti4ct reviewed Apr 25, 2022

View reviewed changes

src/helpers/transaction.ts Outdated Show resolved Hide resolved

Disti4ct reviewed Apr 25, 2022

View reviewed changes

src/components/Statistics/index.tsx Outdated Show resolved Hide resolved

Disti4ct reviewed Apr 25, 2022

View reviewed changes

src/components/Statistics/index.tsx Outdated Show resolved Hide resolved

Disti4ct reviewed Apr 25, 2022

View reviewed changes

src/components/Statistics/index.tsx Outdated Show resolved Hide resolved

src/components/Statistics/index.tsx Outdated Show resolved Hide resolved

VitaliyShulik reviewed Apr 26, 2022

View reviewed changes

src/components/Statistics/index.tsx Outdated Show resolved Hide resolved

VitaliyShulik reviewed Apr 26, 2022

View reviewed changes

src/helpers/transaction.ts Outdated Show resolved Hide resolved

Nasirdin added 2 commits April 27, 2022 15:36

error correction

362c0ff

edit feedback message

271283c

Nasirdin requested review from VitaliyShulik, Disti4ct and noxonsu April 27, 2022 09:54

VitaliyShulik reviewed Apr 27, 2022

View reviewed changes

src/components/Footer/index.tsx Outdated Show resolved Hide resolved

Merge branch 'main' into add-statistics-page

97ca79c

VitaliyShulik reviewed Apr 27, 2022

View reviewed changes

src/constants/index.ts Outdated Show resolved Hide resolved

VitaliyShulik reviewed Apr 27, 2022

View reviewed changes

src/components/Statistics/index.tsx Outdated Show resolved Hide resolved

VitaliyShulik reviewed Apr 27, 2022

View reviewed changes

src/constants/index.ts Outdated Show resolved Hide resolved

VitaliyShulik reviewed May 11, 2022

View reviewed changes

src/components/Statistics/index.tsx Show resolved Hide resolved

VitaliyShulik reviewed May 11, 2022

View reviewed changes

Nasirdin added 3 commits May 17, 2022 00:21

refactoring statistics page

9606573

Merge branch 'main' into add-statistics-page

ee72a10

refactoring statistics page

4e5e6f3

Nasirdin requested a review from VitaliyShulik May 16, 2022 18:36

Disti4ct reviewed May 17, 2022

View reviewed changes

VitaliyShulik reviewed May 17, 2022

View reviewed changes

src/components/Statistics/index.tsx Show resolved Hide resolved

VitaliyShulik reviewed May 17, 2022

View reviewed changes

Nasirdin added 2 commits May 17, 2022 21:58

add new constants and word correction

1398285

Merge branch 'main' into add-statistics-page

b8b233d

Nasirdin requested review from VitaliyShulik and Disti4ct May 17, 2022 16:02

VitaliyShulik reviewed May 18, 2022

View reviewed changes

src/constants/index.ts Outdated Show resolved Hide resolved

VitaliyShulik reviewed May 18, 2022

View reviewed changes

src/components/Statistics/index.tsx Outdated Show resolved Hide resolved

VitaliyShulik reviewed May 18, 2022

View reviewed changes

src/components/Statistics/index.tsx Outdated Show resolved Hide resolved

VitaliyShulik reviewed May 18, 2022

View reviewed changes

src/components/Statistics/index.tsx Show resolved Hide resolved

add loading

964ad66

Nasirdin requested a review from VitaliyShulik May 19, 2022 11:59

Nasirdin added 4 commits May 19, 2022 19:02

add loading

1c946a2

add loading

82ea524

refactoring

66febd5

wrapped the function

31067dd

VitaliyShulik approved these changes May 20, 2022

View reviewed changes

Disti4ct approved these changes May 20, 2022

View reviewed changes

Disti4ct merged commit 3bdaa16 into main May 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add statistics page #105

Add statistics page #105

Nasirdin commented Apr 25, 2022

cloudflare-workers-and-pages bot commented Apr 25, 2022 •

edited

Loading

noxonsu commented Apr 25, 2022

noxonsu commented Apr 25, 2022 •

edited by Nasirdin

Loading

VitaliyShulik commented Apr 26, 2022 •

edited

Loading

Disti4ct commented Apr 26, 2022

VitaliyShulik May 11, 2022 •

edited by Nasirdin

Loading

VitaliyShulik May 11, 2022 •

edited by Nasirdin

Loading

VitaliyShulik commented May 11, 2022 •

edited

Loading

noxonsu commented May 11, 2022

VitaliyShulik commented May 11, 2022

Disti4ct May 17, 2022

Disti4ct May 17, 2022

VitaliyShulik May 17, 2022 •

edited by Nasirdin

Loading

VitaliyShulik left a comment

Add statistics page #105

Add statistics page #105

Conversation

Nasirdin commented Apr 25, 2022

cloudflare-workers-and-pages bot commented Apr 25, 2022 • edited Loading

Deploying with Cloudflare Pages

noxonsu commented Apr 25, 2022

noxonsu commented Apr 25, 2022 • edited by Nasirdin Loading

VitaliyShulik commented Apr 26, 2022 • edited Loading

Disti4ct commented Apr 26, 2022

VitaliyShulik May 11, 2022 • edited by Nasirdin Loading

Choose a reason for hiding this comment

VitaliyShulik May 11, 2022 • edited by Nasirdin Loading

Choose a reason for hiding this comment

VitaliyShulik commented May 11, 2022 • edited Loading

noxonsu commented May 11, 2022

VitaliyShulik commented May 11, 2022

Disti4ct May 17, 2022

Choose a reason for hiding this comment

Disti4ct May 17, 2022

Choose a reason for hiding this comment

VitaliyShulik May 17, 2022 • edited by Nasirdin Loading

Choose a reason for hiding this comment

VitaliyShulik left a comment

Choose a reason for hiding this comment

cloudflare-workers-and-pages bot commented Apr 25, 2022 •

edited

Loading

noxonsu commented Apr 25, 2022 •

edited by Nasirdin

Loading

VitaliyShulik commented Apr 26, 2022 •

edited

Loading

VitaliyShulik May 11, 2022 •

edited by Nasirdin

Loading

VitaliyShulik May 11, 2022 •

edited by Nasirdin

Loading

VitaliyShulik commented May 11, 2022 •

edited

Loading

VitaliyShulik May 17, 2022 •

edited by Nasirdin

Loading