Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tiny11maker.ps1 (Param fix, unique log file with date) #261

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

deftoner
Copy link

Fixed the Define parameters, moved to the top (if not will print error, param needs to be set at the beginning)

Also changed the log output from tiny11.log adding date and time, for better troubleshoot, and to avoid file lock or exist from a previous attempt to run the tool.

Fixed the Define parameters, moved to the top (if not will print error, param needs to be set at the beginning) 

Also changed the log output from tiny11.log adding date and time, for better troubleshoot, and to avoid file lock or exist from a previous attempt to run the tool.
@Karl-WE
Copy link
Contributor

Karl-WE commented Nov 6, 2024

@deftoner appreciate the changes and confirm they are good.
Why replacing Start-Transscript? Without modifying the script there seems to be no logging at all.
What about editing your PR adding a new param?

Fixed the missing transcription. 

Added variable to the date version on title to easy set at the start of the script.
@deftoner
Copy link
Author

@deftoner appreciate the changes and confirm they are good. Why replacing Start-Transscript? Without modifying the script there seems to be no logging at all. What about editing your PR adding a new param?

Hello! thanks for looking into this.

Looks like I didnt save the laste version, didnt want to replace the Start-Transscript, I actually moved it after naming the file with date and time, but looks that I made a mistake and the latest version of the file wasnt saved.

I fixed that, added the missing command, and also added the variable for the release date at the top for easy update on new releases.

Hope this helps

@Karl-WE
Copy link
Contributor

Karl-WE commented Nov 14, 2024

Will Review, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants