Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v5::Subscribe/Unsubscribe packet properties encoding #154

Merged
merged 4 commits into from
Nov 4, 2023

Conversation

fafhrd91
Copy link
Member

@fafhrd91 fafhrd91 commented Nov 4, 2023

No description provided.

@fafhrd91 fafhrd91 changed the title Fix Subscribe packet encoding Fix v5::Subscribe/Unsubscribe packet properties encoding Nov 4, 2023
Copy link

codecov bot commented Nov 4, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (37aa52c) 65.41% compared to head (541cebc) 65.70%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
+ Coverage   65.41%   65.70%   +0.28%     
==========================================
  Files          53       53              
  Lines        9290     9333      +43     
==========================================
+ Hits         6077     6132      +55     
+ Misses       3213     3201      -12     
Files Coverage Δ
src/v5/codec/packet/subscribe.rs 97.57% <100.00%> (+6.39%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fafhrd91 fafhrd91 merged commit a8c37e6 into master Nov 4, 2023
20 of 21 checks passed
@fafhrd91 fafhrd91 deleted the fix-v5-subscribe-encode branch November 4, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant