-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making it simpler to use multiple OneWire buses with an arduino array #2
Open
prashantdev
wants to merge
2
commits into
ntruchsess:master
Choose a base branch
from
prashantdev:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
#include <OneWire.h> | ||
#include <DallasTemperature.h> | ||
|
||
int oneWirePins[]={3,7};//OneWire DS18x20 temperature sensors on these wires | ||
const int oneWirePinsCount=sizeof(oneWirePins)/sizeof(int); | ||
|
||
OneWire ds18x20[oneWirePinsCount]; | ||
DallasTemperature sensor[oneWirePinsCount]; | ||
|
||
|
||
void setup(void) { | ||
// start serial port | ||
Serial.begin(9600); | ||
Serial.println("Dallas Temperature Multiple Bus Control Library Simple Demo"); | ||
Serial.print("============Ready with "); | ||
Serial.print(oneWirePinsCount); | ||
Serial.println(" Sensors================"); | ||
|
||
// Start up the library on all defined bus-wires | ||
DeviceAddress deviceAddress; | ||
for (int i=0; i<oneWirePinsCount; i++) {; | ||
ds18x20[i].setPin(oneWirePins[i]); | ||
sensor[i].setOneWire(&ds18x20[i]); | ||
sensor[i].begin(); | ||
if (sensor[i].getAddress(deviceAddress, 0)) sensor[i].setResolution(deviceAddress, 12); | ||
} | ||
|
||
} | ||
|
||
void loop(void) { | ||
// call sensors.requestTemperatures() to issue a global temperature | ||
// request to all devices on the bus | ||
Serial.print("Requesting temperatures..."); | ||
for (int i=0; i<oneWirePinsCount; i++) { | ||
sensor[i].requestTemperatures(); | ||
} | ||
Serial.println("DONE"); | ||
|
||
delay(1000); | ||
for (int i=0; i<oneWirePinsCount; i++) { | ||
float temperature=sensor[i].getTempCByIndex(0); | ||
Serial.print("Temperature for the sensor "); | ||
Serial.print(i); | ||
Serial.print(" is "); | ||
Serial.println(temperature); | ||
} | ||
Serial.println(); | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line gives me this error:
I guess because there is no constructor that takes an array as argument?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wait, I got a bit confused there... This example is for the
DallasTemperature.h
lib... And is already merged there... However, since this change was never merged into this library, that example won't work with the official version of this library.Another error I'm getting: