-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement reduce stream sdk #91
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
KeranYang
changed the title
feat: implement reduce stream sdk
feat(WIP): implement reduce stream sdk
Jan 15, 2024
Signed-off-by: Keran Yang <[email protected]>
whynowy
reviewed
Jan 18, 2024
src/main/java/io/numaproj/numaflow/reducestreamer/ActorEOFResponse.java
Outdated
Show resolved
Hide resolved
whynowy
reviewed
Jan 18, 2024
Signed-off-by: Keran Yang <[email protected]>
KeranYang
changed the title
feat(WIP): implement reduce stream sdk
feat: implement reduce stream sdk
Jan 18, 2024
Signed-off-by: Keran Yang <[email protected]>
yhl25
reviewed
Jan 22, 2024
examples/src/main/java/io/numaproj/numaflow/examples/reducestreamer/sum/SumFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/io/numaproj/numaflow/reducestreamer/ResponseStreamActor.java
Outdated
Show resolved
Hide resolved
src/main/java/io/numaproj/numaflow/reducestreamer/ReduceSupervisorActor.java
Outdated
Show resolved
Hide resolved
src/main/java/io/numaproj/numaflow/reducestreamer/ActorResponseType.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
Signed-off-by: Keran Yang <[email protected]>
yhl25
reviewed
Jan 23, 2024
src/main/java/io/numaproj/numaflow/reducestreamer/model/Message.java
Outdated
Show resolved
Hide resolved
src/main/java/io/numaproj/numaflow/reducestreamer/model/Metadata.java
Outdated
Show resolved
Hide resolved
src/main/java/io/numaproj/numaflow/reducestreamer/model/OutputStreamObserver.java
Outdated
Show resolved
Hide resolved
src/main/java/io/numaproj/numaflow/reducestreamer/model/ReduceStreamerFactory.java
Outdated
Show resolved
Hide resolved
src/main/java/io/numaproj/numaflow/reducestreamer/OutputActor.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Keran Yang <[email protected]>
yhl25
approved these changes
Jan 23, 2024
KeranYang
added a commit
to KeranYang/numaflow-java
that referenced
this pull request
Jan 22, 2025
* Define the user interface as two methods - processMessage and handleEndOfStream. * Continue using akka to handle concurrency. Introduce an OutputActor to make sure we are sending responses back to the gRPC output stream synchronously. Signed-off-by: Keran Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing: I developed a simple e2e test and it passed. KeranYang/numaflow#97