Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adaptive lookback seconds for monovertex #2299

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from

lint

9dc3c27
Select commit
Loading
Failed to load commit list.
Draft

feat: adaptive lookback seconds for monovertex #2299

lint
9dc3c27
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 23, 2025 in 0s

68.18% (+0.04%) compared to 93bf8f8

View this Pull Request on Codecov

68.18% (+0.04%) compared to 93bf8f8

Details

Codecov Report

Attention: Patch coverage is 68.05252% with 146 lines in your changes missing coverage. Please review.

Project coverage is 68.18%. Comparing base (93bf8f8) to head (9dc3c27).

Files with missing lines Patch % Lines
rust/numaflow-core/src/shared/insecure_tls.rs 0.00% 67 Missing ⚠️
rust/numaflow-core/src/metrics.rs 38.02% 44 Missing ⚠️
...aemon/server/service/rater/rater_lookback_utils.go 87.61% 10 Missing and 4 partials ⚠️
pkg/mvtxdaemon/server/service/rater/rater.go 66.66% 10 Missing ⚠️
pkg/mvtxdaemon/server/service/rater/helper.go 78.12% 5 Missing and 2 partials ⚠️
pkg/mvtxdaemon/server/service/mvtx_service.go 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2299      +/-   ##
==========================================
+ Coverage   68.14%   68.18%   +0.04%     
==========================================
  Files         352      355       +3     
  Lines       46500    46942     +442     
==========================================
+ Hits        31689    32009     +320     
- Misses      13732    13850     +118     
- Partials     1079     1083       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov