Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cpu memory metrics #2332

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

adarsh0728
Copy link
Contributor

@adarsh0728 adarsh0728 commented Jan 15, 2025

  • Adds Memory and CPU pattern in metrics config at pod level
  • Adds Memory and CPU pattern in metrics config at container level [filter values added for container dropdown for a particular pod]
Screenshot 2025-01-20 at 2 35 37 PM Screenshot 2025-01-20 at 2 35 46 PM Screenshot 2025-01-20 at 2 36 05 PM

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 67.47%. Comparing base (05cd792) to head (fa8243e).

Files with missing lines Patch % Lines
server/apis/v1/promql_service.go 40.00% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2332   +/-   ##
=======================================
  Coverage   67.47%   67.47%           
=======================================
  Files         351      351           
  Lines       45822    45827    +5     
=======================================
+ Hits        30918    30922    +4     
  Misses      13828    13828           
- Partials     1076     1077    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adarsh0728 adarsh0728 requested a review from veds-g January 20, 2025 09:07
@@ -115,6 +116,7 @@ export function PodDetail({
pipelineId={pipelineId}
type={type}
vertexId={vertexId}
podDetails={podDetails}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since we are using pod name out of podDetails, can we just pass it instead?

required: false
- name: mono_vertex_pod_cpu_memory_utilization
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we merge monovertex and pipeline patterns for pod and containers, since it is repetitive?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can think of two ways:

  1. Introducing new field (Objects) which is a list. Ensures backward compatibility (no change in existing config), only discovery API needs to check two fields now instead of one.
  2. Making Object field as a list. It has an advantage of having single field but have to change Object field for existing patterns and make sure it doesn't break anything.

@veds-g WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets make it Objects which acts as a llist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants