feat: contextual flow for metrics #2345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
veds-g
commented
Jan 21, 2025
•
veds-g
commented
- adds the framework for contextual redirection of metrics
- covers vertex pending metrics flow
Signed-off-by: veds-g <[email protected]>
veds-g
requested review from
adarsh0728
and removed request for
vigith and
whynowy
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2345 +/- ##
==========================================
+ Coverage 67.47% 67.48% +0.01%
==========================================
Files 351 351
Lines 45822 45822
==========================================
+ Hits 30918 30923 +5
+ Misses 13828 13823 -5
Partials 1076 1076 ☔ View full report in Codecov by Sentry. |
adarsh0728
reviewed
Jan 21, 2025
ui/src/components/common/MetricsModalWrapper/partials/MetricsModal/index.tsx
Outdated
Show resolved
Hide resolved
ui/src/components/common/SlidingSidebar/partials/VertexDetails/partials/Buffers/index.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: veds-g <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.