Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more criteria to detect lifecycle changes, fixes: #2331 #2346

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

whynowy
Copy link
Member

@whynowy whynowy commented Jan 21, 2025

Fixes: #2331

@whynowy whynowy requested a review from vigith as a code owner January 21, 2025 07:05
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.45%. Comparing base (05cd792) to head (3dc1ae2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2346      +/-   ##
==========================================
- Coverage   67.47%   67.45%   -0.02%     
==========================================
  Files         351      351              
  Lines       45822    45823       +1     
==========================================
- Hits        30918    30910       -8     
- Misses      13828    13838      +10     
+ Partials     1076     1075       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@whynowy whynowy changed the title fix: more criteria to detect lifecycle change, fix: #2331 fix: more criteria to detect lifecycle changes, fixes: #2331 Jan 21, 2025
@whynowy whynowy merged commit 3b56306 into numaproj:main Jan 21, 2025
25 checks passed
@whynowy whynowy deleted the addd branch January 21, 2025 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pipeline Pods not scaled back up after being paused
2 participants