Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade Rust to 1.84 #2349

Merged
merged 3 commits into from
Jan 22, 2025
Merged

chore: Upgrade Rust to 1.84 #2349

merged 3 commits into from
Jan 22, 2025

Conversation

BulkBeing
Copy link
Contributor

@BulkBeing BulkBeing commented Jan 22, 2025

Also upgrades some of the dependencies, notably Axum to 0.8.2.
Removes rust/Dockerfile. We do not use this file.

Verified by running Monovertex test/monovertex-e2e/testdata/mono-vertex-with-transformer.yaml

Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: Sreekanth <[email protected]>
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.04%. Comparing base (c492520) to head (473b4cc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
rust/numaflow-core/src/lib.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2349      +/-   ##
==========================================
+ Coverage   67.94%   68.04%   +0.10%     
==========================================
  Files         352      352              
  Lines       46527    46498      -29     
==========================================
+ Hits        31613    31640      +27     
+ Misses      13833    13784      -49     
+ Partials     1081     1074       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vigith
Copy link
Member

vigith commented Jan 22, 2025

we also need to upgrade tower to 0.5.2, currently it is 0.4.x

Signed-off-by: Sreekanth <[email protected]>
@BulkBeing BulkBeing marked this pull request as ready for review January 22, 2025 10:16
@yhl25 yhl25 merged commit a5cd071 into main Jan 22, 2025
28 checks passed
@yhl25 yhl25 deleted the upgrade-rust-1.84 branch January 22, 2025 14:46
jacque1ine pushed a commit to jacque1ine/numaflow that referenced this pull request Jan 23, 2025
Signed-off-by: Sreekanth <[email protected]>
Signed-off-by: jacque1ine <[email protected]>
jacque1ine pushed a commit to jacque1ine/numaflow that referenced this pull request Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants