Skip to content

Commit

Permalink
Revert "NUP-2320 Use WINDOWS_EXPORT_ALL_SYMBOLS instead of MINGW-spec…
Browse files Browse the repository at this point in the history
…ific -export-all-symbols."

This reverts commit 045e0bf.
  • Loading branch information
Vitaly Kruglikov committed Feb 1, 2017
1 parent 60207ae commit 24955c0
Showing 1 changed file with 9 additions and 7 deletions.
16 changes: 9 additions & 7 deletions src/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -497,16 +497,18 @@ if(${NUPIC_IWYU})
PROPERTIES CXX_INCLUDE_WHAT_YOU_USE ${iwyu_path})
endif()

set(_SRC_SHARED_NUPICCORE_LINK_FLAGS)

if(WIN32)
# Turn on explicit export of all symbols. The implicit one is
# disabled by MINGW if any symbol in any object is marked with the
# __declspec(dllexport) attribute
set_target_properties(${_SRC_LIB_SHARED_NUPICCORE} PROPERTIES
WINDOWS_EXPORT_ALL_SYMBOLS ON)
if(MINGW)
# Turn on explicit -export-all-symbols on MINGW. The implicit one is
# disabled if any symbol in any object is marked with the
# __declspec(dllexport) attribute
set(_SRC_SHARED_NUPICCORE_LINK_FLAGS
"${_SRC_SHARED_NUPICCORE_LINK_FLAGS} -Wl,-export-all-symbols")
endif()
endif()

set(_SRC_SHARED_NUPICCORE_LINK_FLAGS)

if (NUPIC_BUILD_PYEXT_MODULES)
if(WIN32)
# On Windows, a self-contained DLL executable is built, so it has to resolve
Expand Down

0 comments on commit 24955c0

Please sign in to comment.