NUP-2320 DO NOT MERGE Convert nupic.core to shared lib. #1216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
February 1, 2017 12:48
…ror from `import nupic.bindings.engine_internal`: ImportError: dlopen(/Users/vkruglikov/Library/Python/2.7/lib/python/site-packages/nupic/bindings/_engine_internal.so, 2): Library not loaded: libnupic_core.dylib Referenced from: /Users/vkruglikov/Library/Python/2.7/lib/python/site-packages/nupic/bindings/_engine_internal.so Reason: unsafe use of relative rpath libnupic_core.dylib in /Users/vkruglikov/Library/Python/2.7/lib/python/site-packages/nupic/bindings/_engine_internal.so with restricted binary In [3]: import nupic.bindings.engine_internal
NUP-2320 Fix installation of nupic_core dll into the prefix/bin directory so that it works on Windows as well, since there it's treated as RUNTIME instead of LIBRARY.
…(needed by PyRegion). Added temp `ls` statement to help debug why libnupic_core.so isn't being found in most Bamboo build targets.
…hared lib to force generation of capnp schema.
…nto nupic_core shared lib that don't have explicit visibility to avoid prining when building on Windows.
…ared library containing capnproto to satisfy capnp references that would normally be satisfied by capnproto in pycapnp.
…mbols to be added to shared libs.
…or Linux and mingw (was failing on mingw without -Wl)
…y dependency on pthread.
NUP-2320 Fix reference to src_common_os_libs variable.
…the prior attempt.
…ports all global symbols.
…RE in src_common_test_exe_libs. NUP-2320 experimentally, comment out the PRIVATE keyword in target_link_libraries of shared libs.
…port-all-symbols.
added 2 commits
February 1, 2017 12:48
…ific -export-all-symbols." This reverts commit 045e0bf.
…g compiler-specific techniques.
vitaly-krugl
force-pushed
the
nup2320-confert-nupic.core-to-sharedlib
branch
from
1306982 to
0e5d18e
Compare
added 12 commits
February 1, 2017 13:39
…ibgcc (not static) to be able to handle exceptions across DLL boundaries.
…s absence was causing a load failure of py_region_test.exe on a Win32 AMI on Amazon.
…ing nupic.bindings.
…c_core lib's LINK_FLAGS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1217.
Work in progress ...