✨(frontend) add fullscreen mode on desktop #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
By default when I enter a room I have "exit full screen" button, which feels weird because I didn't set anything full screen before. Is it only when we are alone in a room ? 
|
|
It also happen when there is > 1 people in the room. Nothing happens when clicking on it. 
|
Enregistrement.de.l.ecran.2025-01-22.a.11.07.06_2_3.mov |
NathanVss
reviewed
Jan 22, 2025
Comment on lines
34
to
50
| {isFullscreenAvailable && ( | ||
| <MenuItem | ||
| onAction={() => toggleFullScreen()} | ||
| className={menuRecipe({ icon: true, variant: 'dark' }).item} | ||
| > | ||
| {isCurrentlyFullscreen ? ( | ||
| <> | ||
| <RiFullscreenExitLine size={20} /> | ||
| {t('fullscreen.exit')} | ||
| </> | ||
| ) : ( | ||
| <> | ||
| <RiFullscreenLine size={20} /> | ||
| {t('fullscreen.enter')} | ||
| </> | ||
| )} | ||
| </MenuItem> |
There was a problem hiding this comment.
WDYT about nesting this in a sub component ?
There was a problem hiding this comment.
I would prefer having all the MenuItem at the same level, but if you feel it's necessary can totally do
There was a problem hiding this comment.
I try something
lebaudantoine
force-pushed
the
full-screen-toggle
branch
from
a5e46d8 to
0034999
Compare
|
Expected behavior Enregistrement.de.l.ecran.2025-01-22.a.13.52.27.mov |
Added an option allowing users to trigger the fullscreen mode while on desktop. Heavily inspired by the PR #279 from @sylvinus. Yet, this option allow user to enable/disable the fullscreen mode on the whole ui, in the next iteration I'll add the same feature but for a given video track. This is on purpose that the feature is available on desktop only. The hook code has been partially written by Claude and inspired by @sylvinus first suggestion.
lebaudantoine
force-pushed
the
full-screen-toggle
branch
from
0034999 to
b3138b4
Compare
Each menu item is now a standalone component, improving: - Code organization & reusability - Maintainability by reducing OptionsMenuItems complexity This breaks down large components.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added an option allowing users to trigger the fullscreen mode while on desktop. Heavily inspired by the PR #279 from @sylvinus.
Yet, this option allow user to enable/disable the fullscreen mode on the whole ui, in the next iteration I'll add the same feature but for a given video track.
This is on purpose that the feature is available on desktop only. The hook code has been partially written by Claude and inspired by @sylvinus first suggestion.