Allow custom room names #315
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following numerous user requests, add support for personalized room names alongside our existing generated IDs. This pattern, inherited from Jitsi Meet, allows teams to create memorable, persistent meeting spaces like "daily-standup" or "teamalpha" instead of relying only on auto-generated IDs. Note: This change introduces a permanent update to room URL patterns. Once custom room links are shared, we will need to maintain support for both formats to avoid breaking existing shared URLs.
Display a "personalized" link modal, inspired by Whereby. The UX and the UI are still cumberstome, however it's fully functional and accessible. It's a "okay" v0, allowing users creating their custom link. Thus we can study this feature traction, and decide whether or not prioritize this feature in the UX.
@manuhabitela create a well-documented modal for users trying to join a meeting. Update it with the last room's link format introduced.
Make the validation rules more maintainable and reusable across the codebase. Particularly useful when these values need to be referenced in multiple validation contexts. The personalize room's link modal needs a step-by-step validation.
lebaudantoine
force-pushed
the
allow-custom-room-names
branch
from
e44e52c to
69457a0
Compare
|
Discussed IRL with Arnaud: with should at least enforce 10char, and at first enables this feature with a feature flag, to only our top users, and gather early feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Inspired by Jitsi's user-friendly approach, adds support for custom room names (e.g., 'team-standup', 'daily-meeting') in addition to the existing system-generated IDs (e.g., 'abc-defg-hij').
/!\ Breaking change: This introduces a permanent update to room URL patterns. Since both formats (system-generated and custom) will be shareable links, we must maintain backwards compatibility to avoid breaking existing URLs.
Proposal
Proposed UX. The UI is quite poor, will enhance it in the next iterations!
Enregistrement.de.l.ecran.2025-01-21.a.21.05.28.mov