Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update nunit 4.0 release notes #842

Merged
merged 10 commits into from
Nov 26, 2023
Merged

Update nunit 4.0 release notes #842

merged 10 commits into from
Nov 26, 2023

Conversation

OsirisTerje
Copy link
Member

Autogenerated release notes for nunit 4.0

@SeanKilleen
Copy link
Member

@OsirisTerje the reason this failed the line length check is that I didn't realize it was automated and fixed it manually last time.

I'll add a commit that ignores the rule for this file.

@@ -2,6 +2,8 @@
href: intro.md
- name: NUnit 4 plans
href: Towards-NUnit4.md
- name: NUnit 3 to 4 migration guide
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: NUnit 3 to 4 migration guide
- name: Migration Guides

This should probably be 1 page for all migration guides. We may want to backport some eventually or build upon them in 4.x -> 5.x.

@@ -15,6 +15,9 @@ uid: breakingchanges
* [FileAssert](../writing-tests/assertions/classic-assertions/File-Assert.md)
* Assert.That overloads with _format_ specification and `params` have been removed in favor of an overload using
`FormattableString`.
* The lowest framework version supported is now version 4.6.2 and .Net 6.0.

See full list of [deprecated issues](https://docs.nunit.org/articles/nunit/release-notes/framework.html#deprecated-features) and [breaking changes](https://docs.nunit.org/articles/nunit/release-notes/framework.html#the-following-issues-are-marked-as-breaking-changes) in the framework.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
See full list of [deprecated issues](https://docs.nunit.org/articles/nunit/release-notes/framework.html#deprecated-features) and [breaking changes](https://docs.nunit.org/articles/nunit/release-notes/framework.html#the-following-issues-are-marked-as-breaking-changes) in the framework.
See full list of [deprecated features](https://docs.nunit.org/articles/nunit/release-notes/framework.html#deprecated-features) and [breaking changes](https://docs.nunit.org/articles/nunit/release-notes/framework.html#the-following-issues-are-marked-as-breaking-changes) in the framework.

@@ -18,7 +18,7 @@
"ms-dotnettools.csharp",
"github.vscode-github-actions",
"ms-azuretools.vscode-docker",
""
"stkb.rewrap"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ℹ️ This ensures re-wrap is available in Codespaces as well as VS Code.

@SeanKilleen SeanKilleen merged commit 1c5d67a into master Nov 26, 2023
7 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 26, 2023
* update nunit 4.0 release notes

* Update version number and header for release notes framework

* Update version number and header for release notes framework

* Update version number and header for release notes framework

* Update version number and header for release notes framework

* Disable rule for release notes

* Add re-wrap by default in dev container

* rewrap breaking changes doc

* Fix trailng space.

* Fix TOC link

---------

Co-authored-by: Sean Killeen <[email protected]> 1c5d67a
@SeanKilleen
Copy link
Member

@OsirisTerje sorry about that, I merged the PR by accident because I had it open on my phone. It was fine as-is and I'll incorporate my tiny follow up notes as a separate PR.

@OsirisTerje OsirisTerje deleted the update40 branch November 26, 2023 20:02
@OsirisTerje
Copy link
Member Author

OsirisTerje commented Nov 26, 2023

I'm fine with that! But awesome if you fix up my broken English :-)

@Siljaaa
Copy link

Siljaaa commented Nov 30, 2023

Hi :)

I am not able to run tests in Visual Studio (.NET7) after upgrading NUnit to version 4.

@manfred-brands
Copy link
Member

I am not able to run tests in Visual Studio (.NET7) after upgrading NUnit to version 4.

@Siljaaa That is a bit vague. What packages are you referencing and what is the error.

@Siljaaa
Copy link

Siljaaa commented Nov 30, 2023

@manfred-brands

NUnit 4.0.0
NUnit.Analyzers 3.10.0
NUnit3TestAdapter 4.5.0

It looks like it does not discover the tests.
Microsoft.VisualStudio.TestPlatform.ObjectModel.TestPlatformException: Could not find testhost

It also did not help to specify the test processor architecture setting.

@manfred-brands
Copy link
Member

@Siljaaa Are you targeting net7.0-windows by any chance? There is a workaround listed in #4564. The code fixes have been made but not yet released.

@OsirisTerje
Copy link
Member Author

OsirisTerje commented Nov 30, 2023

@Siljaaa Please don't raise issues in a closed pull request in the docs repo. This belongs in the nunit repo.

You can ask here: nunit/nunit#4563 or raise a new issue here if you feel that is required: https://github.com/nunit/nunit/issues.

PS: Seems you might be testing a web api or something Minimal: Add the following line in the bottom of your Program.cs:

public partial class Program
{ }

@nunit nunit locked and limited conversation to collaborators Nov 30, 2023
@nunit nunit unlocked this conversation Nov 30, 2023
@Siljaaa
Copy link

Siljaaa commented Nov 30, 2023

@OsirisTerje I apologize, I am so sorry

@manfred-brands Thank you, yes this helped

@OsirisTerje
Copy link
Member Author

@Siljaaa No need to apologize :-) Just trying to point you to where you normally will get most help. Good to hear you're unblocked! Btw, -adev.2 is out on myget. https://www.myget.org/feed/nunit/package/nuget/NUnit/4.1.0-adev.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants