refactor: simplify types in playground store #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for learn-nuxt-com ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
antfu
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! These are just my recommendations to make the types simpler in Pinia. It revolves around letting pinia infer the final types for you and using
export type PlaygroundStore = ReturnType<typeof usePlaygroundStore>to infer the final store type used bymountPlayground().One thing I would personally also do is move (back) the
mountPlaygroundto the store and refactor theactionsobject so they can be regular actions without replacing them at mount. I didn't include those changes to make this refactor clear but let me know if you want me to also add it.I could also come during a stream to explain some of the things if you want, or I can just do it from the chat too.
I didn't know about
Raw<T>, I think I should improve pinia types so adding this manually isn't necessary.