Skip to content

Commit

Permalink
Perform review.handleCaretMove(info) when moving to bookmarks
Browse files Browse the repository at this point in the history
Fixes issue #15
  • Loading branch information
nvdaes committed Feb 26, 2019
1 parent e14dd20 commit 798beeb
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions addon/globalPlugins/placeMarkers/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import globalVars
import languageHandler
import textInfos
import review
from textInfos.offsets import Offsets
from cursorManager import CursorManager
from browseMode import BrowseModeDocumentTreeInterceptor
Expand Down Expand Up @@ -124,6 +125,7 @@ def moveToBookmark(position):
bookmark = Offsets(position, position)
info = obj.makeTextInfo(bookmark)
info.updateSelection()
review.handleCaretMove(info)
speech.cancelSpeech()
info.move(textInfos.UNIT_LINE,1,endPoint="end")
speech.speakTextInfo(info,reason=controlTypes.REASON_CARET)
Expand Down Expand Up @@ -823,6 +825,7 @@ def script_selectNextBookmark(self, gesture):
if nextPos is not None:
info = obj.makeTextInfo(Offsets(nextPos, nextPos))
info.updateSelection()
review.handleCaretMove(info)
if willSayAllResume(gesture):
info.move(textInfos.UNIT_LINE,1,endPoint="end")
#speech.speakTextInfo(info,reason=controlTypes.REASON_CARET)
Expand Down Expand Up @@ -868,6 +871,7 @@ def script_selectPreviousBookmark(self, gesture):
if prevPos is not None:
info = obj.makeTextInfo(Offsets(prevPos, prevPos))
info.updateSelection()
review.handleCaretMove(info)
if willSayAllResume(gesture):
info.move(textInfos.UNIT_LINE,1,endPoint="end")
#speech.speakTextInfo(info,reason=controlTypes.REASON_CARET)
Expand Down
2 changes: 1 addition & 1 deletion buildVars.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
# Translators: Long description to be shown for this add-on on add-on information from add-ons manager
"addon_description" : _("Add-on for setting place markers on specific virtual documents"),
# version
"addon_version" : "12.3",
"addon_version" : "12.4",
# Author(s)
"addon_author" : u"Noelia <[email protected]>, Chris <[email protected]>",
# URL for the add-on documentation support
Expand Down

0 comments on commit 798beeb

Please sign in to comment.