Warn the user if they forgot to set install/abandon date #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #806 +/- ##
=======================================
Coverage 94.88% 94.88%
=======================================
Files 89 89
Lines 3809 3816 +7
=======================================
+ Hits 3614 3621 +7
Misses 195 195 ☔ View full report in Codecov by Sentry. |
WillNilges
reviewed
Jan 10, 2025
Comment on lines
35
to
70
| const saveCurrentDateButton = document.createElement("a"); | ||
| saveCurrentDateButton.className = "button"; | ||
| saveCurrentDateButton.onclick = function () { | ||
| dateField.val(getCurrentISODate()) | ||
| submitAdminForm(saveAction); | ||
| return false; | ||
| } | ||
| saveCurrentDateButton.style = "padding: 10px 15px; display: inline-block; text-decoration: none;"; | ||
| saveCurrentDateButton.href = "#"; | ||
| saveCurrentDateButton.innerText = "Use today's date"; | ||
|
|
||
| const saveNoDateButton = document.createElement("a"); | ||
| saveNoDateButton.className = "button"; | ||
| saveNoDateButton.onclick = function () { | ||
| submitAdminForm(saveAction); | ||
| return false; | ||
| } | ||
| saveNoDateButton.style = "padding: 10px 15px; display: inline-block; margin-left: 10px; text-decoration: none;"; | ||
| saveNoDateButton.href = "#"; | ||
| saveNoDateButton.innerText = "Continue without setting date"; | ||
|
|
||
| const errorNotice = document.createElement("div"); | ||
| errorNotice.id = "dateMissingWarning"; | ||
| errorNotice.className = "warning-box"; | ||
| errorNotice.innerHTML = ` | ||
| <p><b>Warning</b>: Status set to "${statusField.val()}" without setting ${dateType} Date</p> | ||
| `; | ||
| errorNotice.appendChild(saveCurrentDateButton); | ||
| errorNotice.appendChild(saveNoDateButton); | ||
|
|
||
| saveButtons.each((i, button) => { | ||
| $(button).addClass("disabled-button"); | ||
| }) | ||
|
|
||
| $(errorNotice).insertBefore($('.submit-row').first()) | ||
| } |
There was a problem hiding this comment.
Was it really easier to do this than to create another html template? I guess if it works, but this isn't terribly readable.
There was a problem hiding this comment.
I’ll try to implement a template based solution tonight and see how it looks. The nice thing about this approach is that it’s modular and could be used alongside other form widgets
WillNilges
approved these changes
Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a bit of javascript to the Install and Node admin forms which reminds the admin to set the install/abandon date as appropriate if they forget to set it. It's just a reminder but should hopefully encourage folks to actually set these fields
Screen.Recording.2025-01-10.at.00.37.58.mov