Add playwright testing library + intial integration tests for the Join Form #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
WillNilges
commented
Jul 27, 2024
•
WillNilges
commented
- Set up playwright
- Add exhaustive Join Form tests
- Configure GitHub action to point at dev instance of MeshDB
- (optional) Nuke dev instance daily to manage cruft
- Write docs
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
WillNilges
force-pushed
the
wdn/testing
branch
5 times, most recently
from
c243721 to
d8a391b
Compare
WillNilges
changed the title
|
One day, when I grow up, I want to make these tests run on meshdb repo as well <3 Oh and also k8s-infra because fuck you :) |
|
These are a great start on testing, but having PRs on this repo connected to the beta endpoint is not ideal. In theory we'd really like to have unit tests that run on PRs here and just confirm that the generated HTTP request is correct. Then the tests from this PR would be used after PRs are merged, at deploy time to validate that beta is still working in order to gate prod deployments |
Andrew-Dickinson
approved these changes
Aug 1, 2024
WillNilges
force-pushed
the
wdn/testing
branch
2 times, most recently
from
ee38881 to
7550f9e
Compare
|
TODO: Check S3 for submission. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.