fix: try fetch lost layer when unpack image #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If someone removes the content or snapshot by-pass the cri plugin, cir in-memory metadata think the image exists. When we create sandbox or container, we can't find snapshot and unpack from the content layer with the `discard_unpacked_layers` cri config. In that case, we can try fetch the lost image layer to complete create container. Signed-off-by: Yadong Ding <[email protected]>
When CRI has config `discardUnpackedLayers`, we should allows GC to clean layers up from the content store after unpacking. Use ctx to notificate unpack image to gc layer content when retry fetch lost layers. Signed-off-by: Yadong Ding <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone removes the content or snapshot by-pass the cri plugin, cir in-memory metadata think the image exists. When we create sandbox or container, we can't find snapshot and unpack from the content layer with the
discard_unpacked_layersCRI config. In that case, we can try fetch the lost image layer to complete create container.example
discard_unpacked_layers=trueCRI config with overlayfs, pulled OCI images.In that case, we can't find snapshot with nydus sanpshotter. We can't unpack from the content store as well, because we use the
discard_unpacked_layers=trueconfig, the layer had discarded. We can try fetching the lost layer when unpacking image to fix this issue.