Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show loading state so low down #462

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Don't show loading state so low down #462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# Unreleased

- Prevented the loader from taking up 100% of the height of the browser [Pull Request](https://github.com/nylas/components/pull/462)

# 2021-11-29

## 1.1.1
Expand Down
6 changes: 0 additions & 6 deletions components/mailbox/src/Mailbox.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,12 +737,6 @@
gap: 8px;
}

&.loading {
grid-template-rows: minmax(
auto,
calc(100vh - 16px)
); /** loading mailbox minus padding **/
}
&.empty {
grid-template-rows: 68px 33.5px minmax(auto, calc(100vh - 117.5px)); /** header, toolbar, empty mailbox (100vh) minus header, toolbar and padding **/
ul {
Expand Down