Feature: Show threads by ID #465
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bmulholland is attempting to deploy a commit to the Nylas Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
bmulholland
commented
Oct 14, 2022
| // at a time :( | ||
| const queryString = `${getMiddlewareApiUrl( | ||
| query.component_id, | ||
| )}/threads/${thread_id}?view=expanded`; |
There was a problem hiding this comment.
It would be a lot faster if the Nylas API had a way to fetch a list of threads in a single call. Also, fetching the expanded view seems like a lot of data. Combined, these queries are slow and would ideally be improved.
AaronDDM
requested review from
yifanplanet,
a team and
krisgardiner
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code changes
We have a list of threads that we've assembled using our app's "secret sauce," and now want to show the user this curated lists of threads as kind of an automatically created folder. We don't want to create folders or labels for the user, because that gets into preferences of if (and how) they'd like their email data modified.
We also want to make the mailbox UI interactive, which is to say, we want the Nylas component to run HTTP requests. It should load the body of emails, contact data, and write data back, allowing for star/unstar etc. The only current way to display a specific set of threads in the Mailbox is to supply all_threads, but that requires optimistic loading of all data (very slow), and disables all the interactive parts of the component.
This change, previously discussed with Hazik Azfal, adds support for passing in a list of thread IDs, which fulfills all requirements. We're about to deploy the mailbox component to production with this modification (along with other changes in other PRs)
Closes #439
Readiness checklist
CHANGELOG.mdcomponent/src/properties.jsonLicense
I confirm that this contribution is made under the terms of the MIT license and that I have the authority necessary to make this contribution on behalf of its copyright owner.