Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feat zeroize to cipher #5241

Closed
wants to merge 3 commits into from
Closed

Add feat zeroize to cipher #5241

wants to merge 3 commits into from

Conversation

pronebird
Copy link
Contributor

@pronebird pronebird commented Dec 10, 2024

Seeing the following issue when trying to run cargo clippy on nym-vpn-client:

C:\Users\pronebird\Nym\nym-vpn-client\nym-vpn-core>cargo clippy --fix --lib -p nym-vpn-api-client --allow-dirty
    Checking nym-vpn-api-client v1.2.0-dev (C:\Users\pronebird\Nym\nym-vpn-client\nym-vpn-core\crates\nym-vpn-api-client)
error[E0432]: unresolved import `nym_crypto::ctr::cipher::zeroize`
  --> crates\nym-vpn-api-client\src\types\account.rs:5:30
   |
5  | use nym_crypto::ctr::cipher::zeroize::Zeroizing;
   |                              ^^^^^^^ could not find `zeroize` in `cipher`
   |
note: found an item that was configured out
  --> C:\Users\pronebird\.cargo\registry\src\index.crates.io-6f17d22bba15001f\cipher-0.4.4\src\lib.rs:35:9
   |
35 | pub use zeroize;
   |         ^^^^^^^
note: the item is gated behind the `zeroize` feature
  --> C:\Users\pronebird\.cargo\registry\src\index.crates.io-6f17d22bba15001f\cipher-0.4.4\src\lib.rs:33:7
   |
33 | #[cfg(feature = "zeroize")]
   |       ^^^^^^^^^^^^^^^^^^^

For more information about this error, try `rustc --explain E0432`.
error: could not compile `nym-vpn-api-client` (lib) due to 1 previous error

Looks like we're missing the feature flag for cipher which is re-exported via ctr.

This change is Reviewable

Copy link

vercel bot commented Dec 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-nextra ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2024 2:31pm
nym-next-explorer ⬜️ Ignored (Inspect) Visit Preview Dec 10, 2024 2:31pm

@pronebird pronebird marked this pull request as ready for review December 10, 2024 15:26
@pronebird pronebird requested a review from jstuczyn as a code owner December 10, 2024 15:26
@pronebird
Copy link
Contributor Author

Closing in favour of refactoring the code in nym-vpn-client

@pronebird pronebird closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant