code review changes

Signed-off-by: Jan Hanca <[email protected]>
o3de · Dec 11, 2023 · 7f1ce15 · 7f1ce15
1 parent 3fc00d9
commit 7f1ce15
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/Gems/ROS2/Code/Source/RobotImporter/SDFormat/Hooks/ROS2SkidSteeringModelHook.cpp b/Gems/ROS2/Code/Source/RobotImporter/SDFormat/Hooks/ROS2SkidSteeringModelHook.cpp
@@ -41,7 +41,7 @@ namespace ROS2::SDFormat
                     HooksUtils::EnableMotor(entityIdRight);
                     constexpr bool steering = false; // Skid steering model does not have any steering wheels.
                     constexpr bool drive = true;
-                    configuration.m_axles.emplace_back(ROS2::VehicleDynamics::Utilities::Create2WheelAxle(
+                    configuration.m_axles.emplace_back(VehicleDynamics::Utilities::Create2WheelAxle(
                         entityIdLeft, entityIdRight, AZStd::move(tag), wheelDiameter / 2.0f, steering, drive));
                 }
                 else
@@ -193,7 +193,7 @@ namespace ROS2::SDFormat
             }
             else
             {
-                return AZ::Failure(AZStd::string("Failed to create ROS2 Skid Steering Control Component"));
+                return AZ::Failure(AZStd::string("Failed to create ROS 2 Skid Steering Control Component"));
             }
         };
 

diff --git a/Gems/ROS2/Code/Source/RobotImporter/SDFormat/ROS2SDFormatHooksUtils.cpp b/Gems/ROS2/Code/Source/RobotImporter/SDFormat/ROS2SDFormatHooksUtils.cpp
@@ -65,7 +65,6 @@ namespace ROS2::SDFormat
             {
                 const auto wheelComponentPtr = HooksUtils::CreateComponent<VehicleDynamics::WheelControllerComponent>(*entity);
                 AZ_Warning("HooksUtils", wheelComponentPtr != nullptr, "Cannot create WheelControllerComponent in articulation link.");
-
                 return;
             }
         }

diff --git a/Gems/ROS2/Code/Source/RobotImporter/SDFormat/ROS2SDFormatHooksUtils.h b/Gems/ROS2/Code/Source/RobotImporter/SDFormat/ROS2SDFormatHooksUtils.h
@@ -26,10 +26,10 @@ namespace ROS2::SDFormat
 {
     namespace HooksUtils
     {
-        //! Add a ROS2 topic configuration to sensor parameters.
+        //! Add a ROS 2 topic configuration to sensor parameters.
         //! @param sensorConfig sensor's configuration which hosts multiple topic configurations
-        //! @param topic ROS2 topic name
-        //! @param messageType ROS2 message type
+        //! @param topic ROS 2 topic name
+        //! @param messageType ROS 2 message type
         //! @param configName name under which topic configuration is stored in sensor's configuration
         void AddTopicConfiguration(
             SensorConfiguration& sensorConfig,
-Original file line number
+Diff line change
@@ Expand Up / @@ -65,7 +65,6 @@ namespace ROS2::SDFormat @@
                 {
                     const auto wheelComponentPtr = HooksUtils::CreateComponent<VehicleDynamics::WheelControllerComponent>(*entity);
                     AZ_Warning("HooksUtils", wheelComponentPtr != nullptr, "Cannot create WheelControllerComponent in articulation link.");
                     return;
                 }
             }
@@ Expand Down @@