-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
redo SDFormat sensor import condition #632
Merged
michalpelka
merged 1 commit into
o3de:development
from
jhanca-robotecai:jh/redo_sensor_plugins
Jan 25, 2024
Merged
redo SDFormat sensor import condition #632
michalpelka
merged 1 commit into
o3de:development
from
jhanca-robotecai:jh/redo_sensor_plugins
Jan 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switching to draft. This PR will be merged after #609 with some more changes. |
jhanca-robotecai
force-pushed
the
jh/redo_sensor_plugins
branch
from
January 5, 2024 10:26
279f94a
to
caa6d03
Compare
This was referenced Jan 8, 2024
jhanca-robotecai
force-pushed
the
jh/redo_sensor_plugins
branch
from
January 11, 2024 16:37
caa6d03
to
92484b6
Compare
adamdbrw
approved these changes
Jan 18, 2024
michalpelka
approved these changes
Jan 18, 2024
spham-amzn
reviewed
Jan 18, 2024
Gems/ROS2/Code/Source/RobotImporter/ROS2RobotImporterEditorSystemComponent.cpp
Outdated
Show resolved
Hide resolved
arturkamieniecki
approved these changes
Jan 19, 2024
Signed-off-by: Jan Hanca <[email protected]>
jhanca-robotecai
force-pushed
the
jh/redo_sensor_plugins
branch
from
January 23, 2024 15:20
92484b6
to
92e2676
Compare
|
adamkrawczyk
pushed a commit
to RobotecAI/o3de-extras
that referenced
this pull request
Apr 10, 2024
Signed-off-by: Jan Hanca <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous implementation, SDFormat
<sensor>
tag was triggering the import hook based on the sensor type only and it did not use the<plugin>
information at all. Now, the hook is matched based on both. In particular:<plugin>
is implemented for a particular sensor<plugin>
data if availableThis way the user might add their hook with their sensor implementation by using their own plugin name declared in the hook, e.g. it is possible to add a hook for the popular
libhector_gazebo_ros_imu
plugin.Tested using three different camera plugins in sdf files, with standard camera plugin:
without any plugin:
with modified plugin: