Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sub-page describing SDFormat sensor importer #2515

Merged
merged 4 commits into from
Mar 4, 2024
Merged

sub-page describing SDFormat sensor importer #2515

merged 4 commits into from
Mar 4, 2024

Conversation

jhanca-robotecai
Copy link
Contributor

Change summary

  • cherry-pick updated robotics docs #2483 to synchronize development branch with main branch
  • create a sub-category for Robot Importer documentation of ROS 2 Gem
  • add a new sub-page describing SDFormat sensor importer of Robot Importer

Draft pull request: waiting for more changes by @adamdbrw

Submission Checklist:

  • Descriptive active voice - Do descriptive sentences have a clear subject and action verb?
  • Answer the question at hand - Does the documentation answer a what, why, how, or where type of question?
  • Consistency - Does the content consistently follow the Style Guide?
  • Help the user - Does the documentation show the user something meaningful?

@jhanca-robotecai jhanca-robotecai changed the title Jhanca robotecai/sdformat sensors sub-page describing SDFormat sensor importer Dec 11, 2023
@jhanca-robotecai jhanca-robotecai mentioned this pull request Dec 11, 2023
Merged
@jhanca-robotecai jhanca-robotecai marked this pull request as ready for review December 20, 2023 13:53
@jhanca-robotecai jhanca-robotecai requested a review from a team as a code owner December 20, 2023 13:53
adamdbrw
adamdbrw reviewed Dec 21, 2023
View reviewed changes
Copy link
Contributor

@adamdbrw adamdbrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good contribution, take a look at my suggestions please.

Rebase once development is synced.

content/docs/user-guide/_index.md Outdated Show resolved Hide resolved
content/docs/user-guide/interactivity/robotics/_index.md Show resolved Hide resolved
content/docs/user-guide/interactivity/robotics/importing-robot/sdformat-sensors.md Outdated Show resolved Hide resolved
content/docs/user-guide/interactivity/robotics/importing-robot/sdformat-sensors.md Show resolved Hide resolved
content/docs/user-guide/interactivity/robotics/importing-robot/sdformat-sensors.md Show resolved Hide resolved
content/docs/user-guide/interactivity/robotics/importing-robot/sdformat-sensors.md Show resolved Hide resolved
@jhanca-robotecai jhanca-robotecai mentioned this pull request Jan 19, 2024
Merged
4 tasks
@michalpelka
Copy link
Contributor

I manually rebased and force-pushed.
The original branch was backup : https://github.com/michalpelka/o3de.org/tree/mp_bckp/jhanca-robotecai/sdformat_sensors

@michalpelka michalpelka force-pushed the jhanca-robotecai/sdformat_sensors branch from 2cbb293 to a833b18 Compare February 19, 2024 21:29
@adamdbrw adamdbrw merged commit f7db34f into development Mar 4, 2024
5 checks passed
@adamdbrw adamdbrw deleted the jhanca-robotecai/sdformat_sensors branch March 4, 2024 10:11
jhanca-robotecai added a commit that referenced this pull request Jul 4, 2024
@jhanca-robotecai @adamdbrw @michalpelka
sub-page describing SDFormat sensor importer (#2515)
5ae120a 
* updated robotics docs
* add sdformat sensors import description

---------

Signed-off-by: Adam Dabrowski <[email protected]>
Signed-off-by: Michał Pełka <[email protected]>
Signed-off-by: Jan Hanca <[email protected]>
Co-authored-by: Adam Dabrowski <[email protected]>
Co-authored-by: Michał Pełka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdbrw adamdbrw adamdbrw left review comments

@michalpelka michalpelka michalpelka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jhanca-robotecai @michalpelka @adamdbrw