Setup keycloak to run on ovirt engine's wildfly instance #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwperina
requested changes
Dec 14, 2021
There was a problem hiding this comment.
I suggest following:
- Merge Add template for GH action build #4
- Rebase this patch on top of master after step 1, integrate with current GH action build
- Remove all STDCI content (
automation*)
arso
force-pushed
the
keycloak-on-wildfly
branch
7 times, most recently
from
c4fdce7 to
529f8d7
Compare
arso
force-pushed
the
keycloak-on-wildfly
branch
3 times, most recently
from
6d90d41 to
43e14c0
Compare
mwperina
requested changes
Dec 15, 2021
arso
force-pushed
the
keycloak-on-wildfly
branch
from
43e14c0 to
57b4674
Compare
mwperina
reviewed
Dec 16, 2021
arso
force-pushed
the
keycloak-on-wildfly
branch
from
57b4674 to
e611ab7
Compare
didib
reviewed
Dec 16, 2021
packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-keycloak/apache/keycloakproxy.py
Outdated
Show resolved
Hide resolved
packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-keycloak/ovirt-engine/keycloak.py
Show resolved
Hide resolved
packaging/setup/plugins/ovirt-engine-setup/ovirt-engine-keycloak/ovirt-engine/keycloak.py
Show resolved
Hide resolved
arso
force-pushed
the
keycloak-on-wildfly
branch
from
e611ab7 to
0d12388
Compare
Bug-Url: https://bugzilla.redhat.com/2021497 Signed-off-by: Artur Socha <[email protected]> Change-Id: Ie07423fc6f4788e390dc24e1d3a78d0fa0292294
The goal of this patch is to setup Keycloak overlay to run on Ovirt Engine's Wildfly/EAP instance. The activation takes place automatically when engine-setup is run and ovirt-engine-keyclaok-setup & ovirt-engine-keycloak packages are installed. As a prerequisite ovirt-engine's patch [1] providing Wildfly/EAP configuration template must be installed. [1] https://gerrit.ovirt.org/c/ovirt-engine/+/117722 Bug-Url: https://bugzilla.redhat.com/2021497 Signed-off-by: Artur Socha <[email protected]>
arso
force-pushed
the
keycloak-on-wildfly
branch
from
0d12388 to
aac14ea
Compare
|
Generally looks good, I think it's ok to merge as-is and handle the rest later. |
Thanks Didi. I have resolved remaining conversations. @mwperina If you have no more comments to the existing state of this PR then please switch review status from 'changes requested' to 'approved' so that I could merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is initial support for running Keycloak on top of oVirt Engine's Wildfly.
Currently keycloak app is deployed with all the default settings under https:/ENGINE_HOST:PORT://auth