-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add three CRISPR assays #1796
Merged
Merged
Add three CRISPR assays #1796
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
585bceb
Add three CRISPR assays
sebastianduesing a29d3b5
Edit label of OBI:0003660
sebastianduesing 6be7836
Add fourth assay term and standardize labels
sebastianduesing a0a07c0
Remove OBI:0003668
sebastianduesing c1fb85c
Merge branch 'master' into 1784_crispr_assays
jamesaoverton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed that the term name says "single RNA-seq"; I'm not sure if that's accidentally omitting the word "cell" (as in "single cell RNA-seq")?
Also, if it's OK, I'd like to share this pull request with some of our labs working on CRISPR screens to see if they are happy with the terminology.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jenjou Good catch—I believe that change was made while Bjoern was editing the template during the OBI call a couple weeks ago. I'll add a commit to change it to "single-cell RNA-Seq". Yes, please feel free to share this PR with the labs.