Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the data attribute is deprecated #850

Closed
yegor256 opened this issue Nov 8, 2024 · 10 comments
Closed

the data attribute is deprecated #850

yegor256 opened this issue Nov 8, 2024 · 10 comments
Assignees
Labels
blocked This issue is blocked by some other issue enhancement New feature or request good first issue Good for newcomers soon This issue will be solved soon

Comments

@yegor256
Copy link
Member

yegor256 commented Nov 8, 2024

We don't have data="bytes" attribute in XMIR anymore, it's deprecated. You can easily remove it.

@yegor256
Copy link
Member Author

yegor256 commented Nov 8, 2024

@volodya-lombrozo check this one please

@volodya-lombrozo volodya-lombrozo self-assigned this Nov 8, 2024
@volodya-lombrozo volodya-lombrozo added enhancement New feature or request good first issue Good for newcomers soon This issue will be solved soon labels Nov 8, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 13, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 13, 2024
@volodya-lombrozo
Copy link
Member

@yegor256 It's impossible. I tried to remove @data attribute from org.eolang.bytes object and failed. When we do this, eo-maven-plugin:xmir-to-phi goal removes all the bytes from the object.

After disassembling (without data attribute):

<o base="jeo.int" line="1246658856" name="version">
   <o base="org.eolang.bytes">00 00 00 00 00 00 00 34</o>
</o>

Then, after eo-maven-plugin:xmir-to-phi goal:

version ↦ ξ.jeo.int(
  α0 ↦ Φ.org.eolang.bytes
),

As you can see, bytes are lost.

@volodya-lombrozo
Copy link
Member

Blocked by objectionary/eo#3494

@volodya-lombrozo volodya-lombrozo added the blocked This issue is blocked by some other issue label Nov 13, 2024
@yegor256
Copy link
Member Author

yegor256 commented Nov 23, 2024

@volodya-lombrozo the objectionary/eo#3494 is merged and released (0.42.0), you can proceed here

@volodya-lombrozo volodya-lombrozo removed the blocked This issue is blocked by some other issue label Nov 23, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 23, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 23, 2024
@volodya-lombrozo
Copy link
Member

@yegor256 I can't. The issue is still blocked by objectionary/eo#3494

@volodya-lombrozo volodya-lombrozo added the blocked This issue is blocked by some other issue label Nov 24, 2024
@yegor256
Copy link
Member Author

@volodya-lombrozo try version 0.43.0, should work

volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 24, 2024
@volodya-lombrozo
Copy link
Member

@yegor256 With 0.43.0 the previous issue is gone. Now we have a different blocker:
objectionary/eo#3535

@volodya-lombrozo
Copy link
Member

@yegor256 Blocked by objectionary/eo#3534

volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 25, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 27, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 27, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 27, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 27, 2024
volodya-lombrozo added a commit to volodya-lombrozo/jeo-maven-plugin that referenced this issue Nov 27, 2024
@0pdd
Copy link

0pdd commented Nov 27, 2024

@yegor256 the puzzle #909 is still not solved.

@yegor256
Copy link
Member Author

@volodya-lombrozo I believe, this one is fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This issue is blocked by some other issue enhancement New feature or request good first issue Good for newcomers soon This issue will be solved soon
Projects
None yet
Development

No branches or pull requests

3 participants