Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DirectivesProgram.java:132-136: Retrieve License From The... #909

Open
0pdd opened this issue Nov 27, 2024 · 2 comments · May be fixed by #943
Open

DirectivesProgram.java:132-136: Retrieve License From The... #909

0pdd opened this issue Nov 27, 2024 · 2 comments · May be fixed by #943
Assignees
@l3r8yJ
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@0pdd
Copy link

0pdd commented Nov 27, 2024

The puzzle 850-88250cdc from #850 has to be resolved:

jeo-maven-plugin/src/main/java/org/eolang/jeo/representation/directives/DirectivesProgram.java

Lines 132 to 136 in e1d67d3

* @todo #850 Retrieve License From The File.
* We use license as a file in the project root.
* See LICENSE.txt file.
* It's better to read this file and return its content.
* Otherwise, we have to maintain the license in two places.

The puzzle was created by volodya-lombrozo on 27-Nov-24.

role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Nov 27, 2024
@volodya-lombrozo
feat(#850): remove fake data
e1d67d3
@0pdd 0pdd mentioned this issue Nov 27, 2024
Closed
@volodya-lombrozo volodya-lombrozo added bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed labels Nov 27, 2024
@l3r8yJ
Copy link

l3r8yJ commented Dec 6, 2024

@volodya-lombrozo I have two questions for this issue:

  1. Is this license should be consumed from the plugin sources or from project which plugin applied for?
  2. Can you assign this one to me?

@volodya-lombrozo
Copy link
Member

@l3r8yJ

  1. From the jeo-maven-plugin sources. Here it is.
  2. Sure, please, go ahead

l3r8yJ added a commit to l3r8yJ/jeo-maven-plugin that referenced this issue Dec 8, 2024
@l3r8yJ
feat(objectionary#909): move to class; read from resources
0be896a
@l3r8yJ l3r8yJ linked a pull request Dec 8, 2024 that will close this issue
Open
l3r8yJ added a commit to l3r8yJ/jeo-maven-plugin that referenced this issue Dec 9, 2024
@l3r8yJ
feat(objectionary#909): fetch license from github
9c5dce1
l3r8yJ added a commit to l3r8yJ/jeo-maven-plugin that referenced this issue Dec 10, 2024
@l3r8yJ
Revert "feat(objectionary#909): fetch license from github"
94aef76 
This reverts commit 9c5dce1.
l3r8yJ added a commit to l3r8yJ/jeo-maven-plugin that referenced this issue Dec 10, 2024
@l3r8yJ
build(objectionary#909): add plugin to copy license from root
ff93972
l3r8yJ added a commit to l3r8yJ/jeo-maven-plugin that referenced this issue Dec 11, 2024
@l3r8yJ
feat(objectionary#909): add cache
c3f5fd6
l3r8yJ added a commit to l3r8yJ/jeo-maven-plugin that referenced this issue Dec 18, 2024
@l3r8yJ
ci(objectionary#909): remove java 8; add puzzle to bring it back
ffa2e4e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@l3r8yJ l3r8yJ

Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(#909): move to class; read from resources l3r8yJ/jeo-maven-plugin
3 participants
@0pdd @l3r8yJ @volodya-lombrozo