Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Restore MuteCheckBox indeterminate state icon in Yami #10626

Conversation

tytan652
Copy link
Collaborator

@tytan652 tytan652 commented May 1, 2024

Description

Restore MuteCheckBox indeterminate state icon in Yami

Release (before composable theme):
Screenshot from 2024-05-01 10-21-19

Master:
Screenshot from 2024-05-01 10-20-59

PR:
Screenshot from 2024-05-01 10-29-00

Motivation and Context

Found weird that the button was empty rather than yellowish.

How Has This Been Tested?

Launched OBS with a source with audio set to to none of the track.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@tytan652 tytan652 requested a review from Warchamp7 May 1, 2024 08:33
@tytan652 tytan652 added Bug Fix Non-breaking change which fixes an issue UI/UX Anything to do with changes or additions to UI/UX elements. labels May 1, 2024
@tytan652 tytan652 force-pushed the fix_mutecheckbox_indeterminate_state branch 3 times, most recently from c648206 to 69dd36d Compare May 1, 2024 08:47
@tytan652
Copy link
Collaborator Author

tytan652 commented May 1, 2024

Added all "secondary" states like checked and unchecked and the Light variant was using the same icon as base Yami so no change in it.

Light with PR:
Screenshot from 2024-05-01 10-49-51

UI/data/themes/Yami.obt Outdated Show resolved Hide resolved
@tytan652 tytan652 force-pushed the fix_mutecheckbox_indeterminate_state branch 2 times, most recently from a5f763d to bfbd073 Compare May 4, 2024 21:41
@GeorgesStavracas GeorgesStavracas merged commit 0fc4eb8 into obsproject:master May 6, 2024
14 checks passed
@RytoEX RytoEX added this to the OBS Studio (Next Version) milestone May 6, 2024
@tytan652 tytan652 deleted the fix_mutecheckbox_indeterminate_state branch May 6, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue UI/UX Anything to do with changes or additions to UI/UX elements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants