obs-outputs: Adjust HEVCDecoderConfigurationRecord for hvc1 tag #10672
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sets
ps_array_completeness
when creating the HEVC Decoder Configuration Record to 1.Motivation and Context
The
hvc1
tag is used in Enhanced FLV/RTMP and the native MP4 muxer (#10608) because Apple for some reason does not support the more permissivehev1
tag, and one of the requirements laid out in the specification (ISO/IEC 14496-15) is that forhvc1
thearray_completeness
value for parameter sets needs to be1
.FFmpeg also just sets this to 1 if the tag is
hvc1
without any additional checks for bitstream modification and I checked playback of these files on Windows and macOS with various players and browsers so it's probably fine.As far as I can tell this really just means that all SPS/VPS/PPS need to be inside the
HEVCDecoderConfigurationRecord
present in themoov
atom, which is what we do anyways.How Has This Been Tested?
Tested as part of #10608.
Types of changes
Checklist: