Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

linux-pipewire: Use list-based format selector for video capture #11741

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tytan652
Copy link
Collaborator

@tytan652 tytan652 commented Jan 18, 2025

Description

Change the video capture source UX to choose between formats provided as is by PipeWire and avoid providing non-functional combination.

Also it avoid the user to check every format to find the right resolution.

Negotiation is now made with the user selected format (the choice was ignored before).

Also fixes a typo in the name of a structure.

Note

Formatting of the strings case can be discussed, and FPS values (mainly multiple choices per format) could be added.

Before:

Screenshot From 2025-01-18 13-55-52

After:
Screenshot From 2025-01-18 13-57-11

Motivation and Context

Inspired by #10895 and the fact the actual code was not respecting the user chosen format and potentially showing non-available resolution for some formats.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Tweak (non-breaking change to improve existing functionality)

Checklist:

  • My code has been run through clang-format.
  • I have read the contributing document.
  • My code is not on the master branch.
  • The code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@tytan652 tytan652 added Bug Fix Non-breaking change which fixes an issue Enhancement Improvement to existing functionality Seeking Testers Build artifacts on CI Linux Affects Linux labels Jan 18, 2025
Negotiation is now made with the user selected format.

Also fixes a typo in the name of a structure.
@tytan652 tytan652 force-pushed the improve_pw_camera_ux branch from 1fdcb9b to 65891c4 Compare January 18, 2025 13:22
@tytan652 tytan652 added the UI/UX Anything to do with changes or additions to UI/UX elements. label Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Non-breaking change which fixes an issue Enhancement Improvement to existing functionality Linux Affects Linux Seeking Testers Build artifacts on CI UI/UX Anything to do with changes or additions to UI/UX elements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant