Support 4.12 too #352
Merged
Support 4.12 too #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As expected the 4.12 opam install workflow still fails due to the unrelated checksum issue: https://github.com/ocaml-multicore/multicoretests/actions/runs/5131082041/jobs/9230702394 |
|
CI summary:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While rolling a new release, opam-ci shows that the
Utilrestructuring of #342 makes 4.12 a minimum requirement for the util package. This PR thus makes 4.12 a uniform lower bound for all 3 packages.It fails the OPAM installation workflow though - due to an unrelated 4.12.1 checksum failure reported here: ocaml/opam-repository#23837
I've checked locally that the packages work on 4.12.1 though.
Again, this is another reason for splitting off the libraries into a separate repo #351, so that this missing lower-bound would have been caught by ocaml-ci.