Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started going over our existing tests, and discovered a couple of
Array
entries which could easily be targeted withSTM
:for_all
exists
find_opt
find_index
stable_sort
fast_sort
Afterwards, when the 5.0 CI workflows couldn't compile, I realized that
Array.find_index
was a recent 5.1 addition.For now, this PR therefore leaves it commented out, and so leaves us extending with 5/6 of the above.
Handling an entry conditionally will require some machinery and potentially add additional dependencies.
I don't think it is warranted to do so ATM just to target
find_index
... 🤷