-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit macOS Intel+ARM64 runners #458
Conversation
This should fix #359 - a source of occasional false alarms. |
CI summary
In comparison, this PR's macOS-ARM64 Out of 38 workflows 3 failed with 1 genuine issue and 2 borderline false alarms / CI issues. |
In an attempt to trigger an error on the in-house silicon too, adff14c bumps the count to 2500 as already done in #304. Reminding myself of the macOS OCurrent setup from https://tarides.com/blog/2023-08-02-obuilder-on-macos/ I suspect the test is witnessing the difference between ZFS vs whatever the GitHub actions runners are using underneath.
As such, collecting the macOS runners under the same CI system seems reasonable. |
CI summary:
In comparison, this PR's macOS-ARM64 The latter two failures will disappear with the merge and deployment of ocurrent/multicoretests-ci#36 Out of 38 workflows 3 failed with 1 genuine issue and 2 borderline false alarms / CI issues. |
Merging this one as ocurrent/multicoretests-ci#36 has now been merged |
CI summary for merge to None of the 37 workflows failed 🎉 |
For quite some time, GitHub actions only supported macOS on Intel hardware.
That has changed recently: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources
Interestingly, we have used
macos-latest
which then changed hardware underneath our feet.I noticed, because the once-per-week 5.0.0 and 5.1.1 workflows started finding an
STM
Sys
parallel counterexample relatively consistently.(details below)
This PR thus adds explicit macOS Intel (macos-13) and ARM64 (macos-14) workflows, thus collecting them both in the same GitHub actions CI "backend". I'll write a separate PR to remove the macOS ARM64 runners from multicoretests-ci.
Examples of the two latest runs:
https://github.com/ocaml-multicore/multicoretests/actions/runs/9048073196/job/24860738931
https://github.com/ocaml-multicore/multicoretests/actions/runs/9048277550/job/24861161644