Flag every versions of the ocaml package that haven't been released yet with avoid-version #27227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That seems very-reasonable to me, I imagine that we should also flags 5.3.1? |
I forgot about it but yes indeed |
…et with avoid-version See ocaml/opam#6358
kit-ty-kate
force-pushed
the
ocaml-5.4.0-avoid-version
branch
from
72e26f0 to
948cb7a
Compare
kit-ty-kate
changed the title
|
ocaml/opam#6358 has just been merged so this is ready to review. I also took the time to flag previous unreleased versions of ocaml (e.g. 5.0.1, 4.02.4, …) |
|
Thanks a lot! We need to keep this in mind for future compiler releases |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ocaml/opam#6358 would display more clearly which packages are tagged with avoid-version/deprecated. However in the case of
ocamlwhere we would expect5.4.0to be shown in the same way to avoid confusion as to which version is the latest, it is more complicated due to the fact that detecting if such a package needs to be displayed differently would need a request from the solver for each version which seems too costly.Thus i'm proposing to tag the
ocamlpackages that are still unreleased or in their pre-release phase withavoid-versionand to untag them at the same time as the final release (in this case 5.4.0).cc @Octachron does that seem ok to you? If so this step would be to be added to the release documentation.
Not to be merged before ocaml/opam#6358 has been discussed and merged.